Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aggregate_verify no longer accessible targetting wasm32-unknown-unknown #227

Closed
emturner opened this issue Jul 1, 2024 · 5 comments
Closed

Comments

@emturner
Copy link

emturner commented Jul 1, 2024

Previously on min_pk::0.3.10, we were able to use aggregate_verify successfully, when targetting wasm.

However, on upgrading to 0.3.12, this is no longer the case - as the method is hidden behind the std feature flag that we cannot enable.

Is there any way to fix this? Is there a reason why that method would no-longer accessible on 0.3.12? Currently, it's a breaking change in the API for us.

We're using it to verify aggregate payload signatures from within a wasm32 program.

Thank you!

@dot-asm
Copy link
Collaborator

dot-asm commented Jul 1, 2024

Could you test #228? The omission was unintended...

@emturner
Copy link
Author

emturner commented Jul 2, 2024

Hi, I've tested and can confirm that #228 does fix the issue!

@dot-asm
Copy link
Collaborator

dot-asm commented Jul 2, 2024

Cool! I wonder if you could tell a little bit about your environment. Is it based on wasm-pack or something else? In the essence the underlying question is if there is a way to perform github actions tests in an wasm32-unkown-unknown environment, and if you have any ideas/pointers to share :-)

@emturner
Copy link
Author

emturner commented Jul 2, 2024

Of course! It's ultimately compiling into a wasm module, that gets linked against a custom module internally provided by our runtime. The code runs as the program in a tezos smart rollup, compiling against our SDK.

We don't use wasm pack or anything - very much just a plain cargo build --target wasm32-unknown-unknown.

We don't end up running any tests at all within a wasm32 environment, any unit tests all run natively (but we do run separate e2e tests against the full stack with the compiled module).

Hope that makes rough sense - happy to go into it more if you have any specific questions?

@dot-asm dot-asm closed this as completed in 71a0087 Jul 3, 2024
@dot-asm
Copy link
Collaborator

dot-asm commented Jul 3, 2024

Thanks! It doesn't sound like something I'd be willing to put together and maintain as GA test, too many moving parts... We do exercise wasi and emscripten builds, so it's not like wasm is in total darkness:-) And thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants