Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'leanpub-start-delete' not working as expected @ Kindle versions #433

Open
dcarral opened this issue Apr 16, 2017 · 1 comment
Open

'leanpub-start-delete' not working as expected @ Kindle versions #433

dcarral opened this issue Apr 16, 2017 · 1 comment

Comments

@dcarral
Copy link

dcarral commented Apr 16, 2017

In manuscript/getting_started/03_implementing_notes.md we have:

ReactDOM.render(
leanpub-start-delete
  <div>Hello world</div>,
leanpub-end-delete
leanpub-start-insert
  <Notes />,
leanpub-end-insert
  document.getElementById('app')
);

The (recently) downloaded MOBI version, however, keeps showing the <div>Hello world</div> line. No idea how I can further help debugging/troubleshooting the issue though, let me know if you'd appreciate more info from my side.

Edited issue: shortly after reporting it realized that the problem is with the markup, and not the snippet itself ;)

@dcarral dcarral changed the title Extra parameter passed to ReactDOM.render @ chapter 3? 'leanpub-start-delete' not working as expected @ Kindle versions Apr 16, 2017
@bebraw
Copy link
Member

bebraw commented Apr 16, 2017

Thanks, I have to inspect that to see what's going on. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants