Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedded registry renders Kubernetes resources even when Kubernetes is not configured #267

Closed
atanasdinov opened this issue Mar 5, 2024 · 0 comments · Fixed by #269
Closed

Embedded registry renders Kubernetes resources even when Kubernetes is not configured #267

atanasdinov opened this issue Mar 5, 2024 · 0 comments · Fixed by #269
Assignees
@atanasdinov
Labels
bug Something isn't working triaged The team has reviewed the issue
Milestone
v1.0.0

Comments

@atanasdinov
Copy link
Contributor

atanasdinov commented Mar 5, 2024 •
edited
Loading

Parsing Helm charts (provided under /kubernetes/helm) and Kubernetes manifests (provided under /kubernetes/manifests) is done within the "Embedded Registry" component and does not perform a Kubernetes configuration check.

EIB must fail in the cases where these resources are provided but a Kubernetes version is not set (and thus cluster will not be provisioned).
@atanasdinov atanasdinov self-assigned this Mar 5, 2024
@atanasdinov atanasdinov added bug Something isn't working triaged The team has reviewed the issue labels Mar 5, 2024
@atanasdinov atanasdinov added this to the 1.0.0 milestone Mar 5, 2024
@atanasdinov atanasdinov changed the title Helm charts are rendered even when Kubernetes is not configured Embedded registry renders Kubernetes resources even when Kubernetes is not configured Mar 6, 2024
@atanasdinov atanasdinov mentioned this issue Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@atanasdinov atanasdinov

Labels
bug Something isn't working triaged The team has reviewed the issue
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

Prevent manifests and charts parsing if Kubernetes is not configured atanasdinov/edge-image-builder
1 participant
@atanasdinov