Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow for saving inside prefabs, fixes #73 #104

Closed
wants to merge 1 commit into from

Conversation

GotoFinal
Copy link
Contributor

Based on https://stackoverflow.com/questions/65001961/unity3d-how-to-save-part-of-a-prefab-instance-as-a-prefab
Might require more testing to make sure it always behaves as expected. I tested on my prefab setup, where I removed the emoface prefab from the actual prefab and scene and then:

  1. Used Apply To Avatar on this clean prefab instance - worked like before
  2. Used Apply to Avatar again on this instance - worked like before overriding the old object.
  3. Saved that instance as an actual prefab
  4. Used Apply to Avatar again on this instance - it saved the changes directly to actual prefab, updating all other variants using this prefab. (this crashed before)

The solution might seems a bit hacky I guess... But personally it does what I would like the tool to do.

@suzuryg
Copy link
Owner

suzuryg commented Jan 11, 2024

Thanks for the suggestion!
Actually, there is an implementation for #73 that I had been working on locally, but I had not pushed it to github...
I have just pushed it and created a PR (#106) , so I would like to close this PR.
I may make some code rework on this one before merging.

@suzuryg suzuryg closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants