Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting for sizes #8

Open
sveetch opened this issue Jan 22, 2023 · 0 comments
Open

Setting for sizes #8

sveetch opened this issue Jan 22, 2023 · 0 comments
Labels
question Further information is requested

Comments

@sveetch
Copy link
Owner

sveetch commented Jan 22, 2023

Proposal

A new setting which define shared sizes for thumb alike:

{
    "article-detail-cover": (320x240),
    "category-item-media": (300x200),
}

Template tags will have to recognize size name when given instead of explicite dimensions. Or at least a new tag dedicated to use named sizes.

Pros

It will promotes standardized sizes through templates and avoid to have 42 different sizes among all templates.

Also it will help to pre generate thumb and avoid Sorl retaining page loading until it finished to generate every thumb cache.

Cons

From previous experienced thumb libraries, i know some web designers dont like to change settings when trying to find a proper size, often leading to stale size setting.

There may be some other cons (or pros) but it would need some thought about implementation.

@sveetch sveetch added the question Further information is requested label Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant