-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[adapter api]: pass svelte.config.js config object to adapter #1435
Comments
jthegedus
changed the title
[adapter api]: pass svelte.config object to adapter.
[adapter api]: pass svelte.config.js config object to adapter
May 12, 2021
@jthegedus any chance you'd want to send a PR for this? I think we could do something like:
|
Happy to create the PR 😁 Would an object be preferable? -adapt(utils, config) {
+adapt({ utils, config }) { Would break all adapters once, then never again should something like this come up |
Yes, that's a good idea. We've tried to follow that pattern generally, but I guess we missed doing it here |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
The Firebase adapter reads a provided
firebase.json
configuration to determine destination dirs forutils.copy_{static/client}_files
etc.If the destination dir defined in
firebase.json
is the same as thesvelte.config.js:kit.files.assets
dir then we end up with a mess of a dir similar to the issue I am experiencing from #587Describe the solution you'd like
Either:
utils.copy_{static/client}_files
error when the destination dir is the same as the source dir (notably this missesutils.prerender
, but calling prerender after the other copies would be enough)Describe alternatives you've considered
How important is this feature to you?
It will help reduce noise from known causes in the adapter workflow if I can nudge my users properly
Additional context
jthegedus/svelte-adapter-firebase#56 is the tracking issue for identifying this conflict of a matching
source:dest
for static assets.[update] I have temporarily worked around this by reading the
svelte.config.js
in the adapter, though obviously not ideal as it's the source config and not the computed final config.The text was updated successfully, but these errors were encountered: