Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider changing rawBody to be the bytes #1893

Closed
benmccann opened this issue Jul 13, 2021 · 0 comments · Fixed by #2215
Closed

Consider changing rawBody to be the bytes #1893

benmccann opened this issue Jul 13, 2021 · 0 comments · Fixed by #2215
Labels
adapters - general Support for functionality general to all adapters breaking change
Milestone

Comments

@benmccann
Copy link
Member

Describe the problem

rawBody sounds to me like its the bytes. Sometimes we put bytes in there and sometimes we put text in there depending on the content type. The biggest issue with this in my mind is that we're making each adapter responsible for that logic, but I think it could live in kit

Describe the proposed solution

Move body parsing from the adapter to kit

Alternatives considered

status quo

Importance

nice to have

Additional Information

No response

@benmccann benmccann added the adapters - general Support for functionality general to all adapters label Jul 13, 2021
@benmccann benmccann added this to the 1.0 milestone Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adapters - general Support for functionality general to all adapters breaking change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant