Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svelte-kit package is not replacing all instances of $lib with the relative path #2034

Closed
chanced opened this issue Jul 29, 2021 · 2 comments

Comments

@chanced
Copy link

chanced commented Jul 29, 2021

Describe the bug

Running svelte-kit package does not replace all instances of $lib with the appropriate relative path.

Reproduction

git clone git@github.com:chanced/filedrop-svelte.git
cd filedrop-svelte
npm install
npm run package
grep -r "\$lib" ./package

Altenative:
visit this REPL https://svelte.dev/repl/caa3a71563d5480dbd9f55dcf8466073?version=3

Invalid package name "$lib" (name can only contain URL-friendly characters)

Logs

~/Projects/filedrop  main ✔                                                                                                                                                        0m  
▶ npm run package                                     

> filedrop-svelte@0.0.2 package
> svelte-kit package


~/Projects/filedrop  main ✔                                                                                                                                                        0m  
▶ grep -r "\$lib" ./package                           
./package/components/FileDrop/FileDrop.svelte:<script lang="ts">import filedrop from "$lib/actions/filedrop";
./package/components/FileDrop/FileDrop.svelte:import { isString, isArrayOfStrings } from "$lib/util";
./package/actions/filedrop.js:import { getFilesFromEvent, extractFilesFromEvent, isEventWithFiles, isNode } from "$lib/event";
./package/actions/filedrop.js:import useragent from "$lib/useragent";
./package/actions/filedrop.d.ts:import type { FileDropOptions } from "$lib/options";

System Info

System:
    OS: macOS 11.4
    CPU: (8) x64 Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz
    Memory: 2.77 GB / 16.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 14.17.1 - ~/.nvm/versions/node/v14.17.1/bin/node
    Yarn: 1.22.10 - ~/.nvm/versions/node/v14.17.1/bin/yarn
    npm: 7.19.0 - ~/.nvm/versions/node/v14.17.1/bin/npm
  Browsers:
    Brave Browser: 79.1.1.23
    Chrome: 92.0.4515.107
    Firefox: 89.0
    Safari: 14.1.1
  npmPackages:
    @sveltejs/kit: next => 1.0.0-next.138
    svelte: 3.40.1 => 3.40.1

Severity

blocking all usage of SvelteKit

Additional Information

No response

@ignatiusmb
Copy link
Member

Duplicate of #1950

@chanced
Copy link
Author

chanced commented Jul 29, 2021

Ugh, I'm horrible at this. I searched through the issues and didn't see that one.

I'm sorry. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants