Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title deduplication wrongly uses parent title #2146

Closed
vwkd opened this issue Aug 9, 2021 · 1 comment
Closed

Title deduplication wrongly uses parent title #2146

vwkd opened this issue Aug 9, 2021 · 1 comment

Comments

@vwkd
Copy link

vwkd commented Aug 9, 2021

Describe the bug

If the parent component declares a title after the child component tag, then the parent component's title is used instead of the child component's.

According to @Conduitry in #2009 (comment) the title of the deepest child component should be used instead.

<title> is replaced by lower-level components

Reproduction

See https://github.com/vwkd/sveltekit-bugs/tree/wrong-title

This example uses probably the most common case where the parent component is the layout component and the child component is the index component. But the issue occurs for any parent and child component pair.

Logs

No response

System Info

System:
    OS: macOS 11.5
  Binaries:
    Node: 16.6.0 - ~/.nvm/versions/node/v16.6.0/bin/node
    npm: 7.19.1 - ~/.nvm/versions/node/v16.6.0/bin/npm
  Browsers:
    Chrome: 92.0.4515.131
    Firefox: 90.0.2
    Safari: 14.1.2
  npmPackages:
    @sveltejs/adapter-static: ^1.0.0-next.11 => 1.0.0-next.16 
    @sveltejs/kit: next => 1.0.0-next.142 
    svelte: ^3.34.0 => 3.42.1

Severity

annoyance

Additional Information

No response

@benmccann
Copy link
Member

Duplicate of #1540

@benmccann benmccann marked this as a duplicate of #1540 Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants