Non-GET
shadow endpoint status
response not respected
#3721
Labels
bug
Something isn't working
p1-important
SvelteKit cannot be used by a large number of people, basic functionality is missing, etc.
Milestone
Describe the bug
Returning an error
status
(4xx/5xx) from a non-GET
shadow endpoint is not properly being inherited by the final rendered page, which is always a 200 (assuming the implicitGET
afterwards succeeded).Reproduction
https://github.com/Conduitry-Repros/kit-3721
Logs
No response
System Info
Severity
blocking an upgrade
Additional Information
I assume this is because in
load_node
we are only looking atshadow.status
whenshadow.error
orshadow.redirect
are set. We should also look atshadow.status
when the page has noload
function (whether or not we haveshadow.body
).I'm not sure about whether we want to use
shadow.status
if there's amod.load
and it doesn't return its ownstatus
.The text was updated successfully, but these errors were encountered: