-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a way for layouts to determine if current page is an error page #598
Comments
Created a new kit/packages/kit/src/core/create_app/index.js Line 191 in 64d0291
The one downside of this approach is that we'll get |
Could we partially relieve that by having the starter template define the prop in the root layout, even if it doesn't use it? That might not be worth it though, and would add bytes to the prod version just to avoid a dev time warning. I'm torn. |
I think Svelte should probably skip the warning in cases where the prop is undefined anyway. Relatedly, we have a similar problem with it often warning that a default slot was provided to a leaf component |
We decided that the best way to do this would be import { status, error } from '$app/stores'; |
closed via #3096 |
In Sapper we did sveltejs/sapper#1498
Suggestion from Rich for SvelteKit:
The text was updated successfully, but these errors were encountered: