diff --git a/.changeset/healthy-cows-walk.md b/.changeset/healthy-cows-walk.md new file mode 100644 index 000000000000..fb4513c79342 --- /dev/null +++ b/.changeset/healthy-cows-walk.md @@ -0,0 +1,6 @@ +--- +'@sveltejs/adapter-cloudflare': patch +'@sveltejs/adapter-cloudflare-workers': patch +--- + +[breaking] Don't pass arbitrary options to esbuild diff --git a/packages/adapter-cloudflare-workers/index.js b/packages/adapter-cloudflare-workers/index.js index ddf5aadcd47f..7bfd7634828a 100644 --- a/packages/adapter-cloudflare-workers/index.js +++ b/packages/adapter-cloudflare-workers/index.js @@ -15,7 +15,14 @@ import { fileURLToPath } from 'url'; */ /** @type {import('.').default} */ -export default function (options = {}) { +export default function () { + // TODO remove for 1.0 + if (arguments.length > 0) { + throw new Error( + 'esbuild options can no longer be passed to adapter-cloudflare-workers — see https://github.com/sveltejs/kit/pull/4639' + ); + } + return { name: '@sveltejs/adapter-cloudflare-workers', @@ -58,11 +65,10 @@ export default function (options = {}) { platform: 'browser', sourcemap: 'linked', target: 'es2020', - ...options, entryPoints: [`${tmp}/entry.js`], outfile: main, bundle: true, - external: ['__STATIC_CONTENT_MANIFEST', ...(options?.external || [])], + external: ['__STATIC_CONTENT_MANIFEST'], format: 'esm' }); diff --git a/packages/adapter-cloudflare/index.js b/packages/adapter-cloudflare/index.js index 7cd48539a8eb..41c4f2477f68 100644 --- a/packages/adapter-cloudflare/index.js +++ b/packages/adapter-cloudflare/index.js @@ -4,7 +4,14 @@ import { fileURLToPath } from 'url'; import * as esbuild from 'esbuild'; /** @type {import('.').default} */ -export default function (options = {}) { +export default function () { + // TODO remove for 1.0 + if (arguments.length > 0) { + throw new Error( + 'esbuild options can no longer be passed to adapter-cloudflare — see https://github.com/sveltejs/kit/pull/4639' + ); + } + return { name: '@sveltejs/adapter-cloudflare', async adapt(builder) { @@ -40,7 +47,6 @@ export default function (options = {}) { platform: 'browser', sourcemap: 'linked', target: 'es2020', - ...options, entryPoints: [`${tmp}/_worker.js`], outfile: `${dest}/_worker.js`, allowOverwrite: true,