Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No (separate) source maps for PostCSS #251

Closed
dummdidumm opened this issue Sep 16, 2020 · 1 comment
Closed

No (separate) source maps for PostCSS #251

dummdidumm opened this issue Sep 16, 2020 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@dummdidumm
Copy link
Member

Describe the bug
When preprocessing PostCSS, there is no source map returned although PostCSS supports it.

To Reproduce
Preprocess any file with postcss and see that map of the returned object is undefined.

Expected behavior
A map object is returned.

Reason / how to fix this
PostCSS's SourceMap options have an option inline which is true by default. The result is that the source maps are inlined in the output and not returned in the map object. Setting this to false will fix this. I suggest to make inline: false the default but also allow to override these options. Currently this is not possible.

Information about your project:

  • Your browser and the version: -

  • Your operating system: Windows

  • svelte-preprocess version (Please check you can reproduce the issue with the latest release!): Latest

  • Whether your project uses Webpack or Rollup: Rollup

Additional context

Would be great to have this so we can process the information in language-tools and show Svelte warnings at the correct positions.

@HelenDias
Copy link

Hi @kaisermann! Can you assignee me to this bug?
I would like to help 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants