-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could not open +page.svelte in the editor #943
Comments
caused by yyx990803/launch-editor@5366f3e launch-editor tries to protect from malicious filenames, not sure if + is a dangerous char on windoes or just too rigid check |
fix could take a bit as launch-editor is bundled in vite |
The linked change was included in vite 5.3.2 |
and how to fix this now? I got most recent versions and still get this error. |
this needs a change in |
As a temporary fix force vite to be version 5.3.1 in your package.json: |
please don't use partial overrides. If svelte-inspector on +page.svelte files is that important to you, go back to vite 5.3.1 entirely to ensure that you are using one consistent version. |
the fix for this is going to be included in the next release of vite |
Still doesn't work for me with |
can you provide more info here? the fix was pretty straight forward and another windows user just reported it working with 5.4. can you open files that do not contain a + in their name? Which windows shell and ide versions? |
Yes, I sometimes can open files that don't contain a + but it's hit and miss. Sometimes even navigating to a component fails: app:dev: Could not open BulkReplaceSheet.svelte in the editor.
app:dev:
app:dev: When running on Windows, file names are checked against a safe file name pattern to protect against remote code execution attacks. File names may consist only of alphanumeric
characters (all languages), periods, dashes, slashes, and underscores. My vscode version is 1.92.0 and I am running powershell |
Does your username or the project directory contain any other special characters? |
oof, [] and () are problems tooo i guess |
can confirm this is still an issue with
Referencingissue: yyx990803/launch-editor#50 |
Happening for me on Win10 as well, after update to latest version of SvelteKit 2. Only seems to happen when inspecting elements on routes (+page.svelte), or on components not inside of routes with params. I'm guessing '+' and '[]' are not on the aforementioned safe file name pattern. Components living anywhere else seem to work fine. |
Any updates on this? |
latest version of launch-editor and vite should have this fixed. if you still experience files that do not open please share their full path (skip your user dir for privacy if you prefer but mention if it has any special chars) |
Actually a simple test project does work. However I tested this path from an actual production project and it fails: |
The fix is in launch-editor 2.9.1 which has been merged into vite main branch (6.0 beta) but not backported to 5.4 branch yet, sorry. still needs to wait a bit |
please try again with vite 5.4.9 |
Yes it works now, thanks |
Describe the bug
Randomly started getting this error on my Svelte projects recently when using the code inspector to open up files. Have no idea how to resolve. It only affects files with special characters in the name.
Reproduction URL
https://github.com/sveltejs/vite-plugin-svelte/issues/new
Reproduction
Sorry, do not know how to replicate. Looking for advice on how to fix.
Logs
No response
System Info
The text was updated successfully, but these errors were encountered: