New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary `Wand` parameter in `Task` creation functions #77

Merged

svengreb merged 1 commit into main from improvement/gh-76-remove-wand-param-task-create-funcs

Apr 22, 2021

Owner

svengreb commented Apr 22, 2021

Resolves #76


          Remove unnecessary Wand parameter in Task creation functions

2aa829d

Before most `Task` creation functions [^1] [^2] [^3] [^4] required a
`Wand` as parameter which was not used but blocked the internal usage
for task runners. Therefore these parameters have been removed.
When necessary, it can be added individually later on or can be
reintroduced through a dedicated function with extended parameters to
cover different use cases.

[^1]: https://pkg.go.dev/github.com/svengreb/wand@v0.5.0/pkg/task/gofumpt#New
[^2]: https://pkg.go.dev/github.com/svengreb/wand@v0.5.0/pkg/task/goimports#New
[^3]: https://pkg.go.dev/github.com/svengreb/wand@v0.5.0/pkg/task/golang/build#New
[^4]: https://pkg.go.dev/github.com/svengreb/wand@v0.5.0/pkg/task/golang/install#New

GH-76

svengreb added type-improvement context-api scope-maintainability scope-quality labels

svengreb added this to the 0.6.0 milestone

svengreb self-assigned this

svengreb merged commit 536556b into main

svengreb deleted the improvement/gh-76-remove-wand-param-task-create-funcs branch

April 22, 2021 19:05

svengreb removed their assignment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

context-api scope-maintainability scope-quality type-improvement