Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PaginationPage should inherit from PageWithoutAFile #257

Open
6twenty opened this issue Dec 17, 2023 · 0 comments
Open

PaginationPage should inherit from PageWithoutAFile #257

6twenty opened this issue Dec 17, 2023 · 0 comments

Comments

@6twenty
Copy link

6twenty commented Dec 17, 2023

PaginationPage documents do not map to a single source file on disk, so they should use PageWithoutAFile so that they can be identified as such. PageWithoutAFile is just a very light abstraction class that inherits from Page, so no other changes are required other than renaming PaginationPage < Page to PaginationPage < PageWithoutAFile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant