-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
should keep unicode space char #1150
Comments
It's a parser issue, SVGO uses https://github.com/isaacs/sax-js parser, and as XML parser it eats spaces. |
it's latest commit on 2017 😶 any solution? fix sax-js ? |
Sax-js is no longer maintained after version 1.2.7 released, but I discovered a fork of this parser in their issues. This is under active maintaince, but has some differences than original one. |
@KrasnayaPloshchad: So it wouldn't be that hard to replace sax.js with saxes? PR: #1281 |
I think yes. But if there is regression bring by saxes itself that is impossible to fix by pull request, or saxes developer have no idea for what you need to fix, you can try other alternates anyway. |
Edit: The txml parser is an excellent candidate for which a PR is ready! |
This was not an issue in sax, and rather was a configuration issue on our end. A contributor corrected this for us, and the fix was released in SVGO v2.1.0:
The optimizing the SVG works as expected in SVGO v3.2.0. |
input
output
i want keep spaces, but even i use unicode space char, it's still removed, bug ?
The text was updated successfully, but these errors were encountered: