Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use esbuild instead of rollup #1739

Closed
LeoDog896 opened this issue Jan 17, 2023 · 1 comment
Closed

Use esbuild instead of rollup #1739

LeoDog896 opened this issue Jan 17, 2023 · 1 comment

Comments

@LeoDog896
Copy link

LeoDog896 commented Jan 17, 2023

ESbuild is magnitudes faster for development than rollup, but requires the source package to be ESM. Converting to ESM, however, has been discussed in #1429. If a discussion does happen for using ESM modules, a separate issue should be raised.

There is a workaround for using require which usually works and can be implemented.

@SethFalco
Copy link
Member

Hey! Thanks for the suggestion.

I'm closing this because while we could move to esbuild, there's no significant reason to. We're not having any problems with Rollup, it's still maintained, it's already working out great for bundling, etc.

We could always consider switching in future if any of that ever changes, but right now, it doesn't make sense to change it to address an issue that isn't affecting us.

@SethFalco SethFalco closed this as not planned Won't fix, can't repro, duplicate, stale Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants