Fix NDB Source object's counting and update documentation #1156
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following code snippet gives me an error, but with other objects that works fine.
With this patchset applied I got the following output:
The reason behind the absence of this method is that
Source
subclassesdict
, and there is no real interface in terms of typing that is common toSource
and other NDB objects (which subclassRTNL_object
). Therefore, with this PR, I am addressing only the consequence, not the root cause.Also sources documentation has usage of an inexistent method
.details()
, so I gave some love to the docs too.The the one thing I'm not sure, is the following statement:
It seems I have 2 sources on my pretty default setup. So waiting for your guidance here :)