Merge models from multiple resource definition #610
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for sending this. What version of swagger are you using? I believe that 1.3.6 was updated to support this but perhaps you've found an issue. |
|
I'm using swagger core 1.3.5. I will try to check it with new version of swagger. |
|
It is working ok in swagger 1.3.6, so no fix is need. |
|
After release it seems not working with 1.3.6. I could have locally cached artifact with my fix when I was make test last time :/ |
fehguy
added a commit
that referenced
this pull request
Jul 12, 2014
|
OK fixed. It looks like the api declarations were being merged, but the models were not. That would have made inconsitent results when merging, depending on reflection order. The above patch should fix this permanently. |
|
see 1.3.7-SNAPSHOT in sonatype snapshots for an artifact |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using swagger with JAX-RS. My project has resource which is split into two facades. Both facades have the same path and api key. Swagger correctly merge all methods from both facades with description but it is not merging definition of models. So models definitions are present only for facade which was scanned first and second has only empty class name. I'm referring to models definitions which are used inside “Response Class” and for input parameters “Data Type”.
I have created example patch which fix the problem. Unfortunately my scala knowledge is poor and it most likely could be improved.