Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty link rendered when no external docs #6975

Closed
anthony-kopczyk opened this issue Feb 19, 2021 · 0 comments · Fixed by #6997
Closed

Empty link rendered when no external docs #6975

anthony-kopczyk opened this issue Feb 19, 2021 · 0 comments · Fixed by #6997

Comments

@anthony-kopczyk
Copy link

Q&A (please complete the following information)

  • OS: Windows / WSL
  • Browser: Chrome
  • Method of installation: npm
  • Swagger-UI version: 3.43.0
  • Swagger/OpenAPI version: OpenAPI 3.0

Describe the bug you're encountering

When an API specification is loaded that does not have external docs, an empty link is rendered on the page.

To reproduce...

Load an API specification into swagger UI that does not have external docs.

Expected behavior

There should be not be an empty link on the page for external doc information

Screenshots

image

Additional context or thoughts

This looks like it was in one of the latest changes of the info component. A condition was changed from checking externalDocsUrl to externalDocs. Because externalDocs is a map it's always truthy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant