Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable displayRequestDuration prop for react #7522

Merged
merged 4 commits into from
Jan 18, 2022

Conversation

mathis-m
Copy link
Contributor

Description

added displayRequestDuration to react props.

Motivation and Context

Fixes #7457

How Has This Been Tested?

not

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@char0n char0n self-assigned this Sep 24, 2021
@char0n char0n self-requested a review September 24, 2021 07:59
Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR!

Given we're currently in v4 RC release phase and this PR can be considered a feature, I'd postpone it and merge it right after release/4.x branch has been merged on master.

Unless we can somehow argument that this PR is technically a bugfix ;]

@mathis-m
Copy link
Contributor Author

@char0n sounds good, I have one unrelated question will there be a new petstore4.swagger.io site?

@char0n
Copy link
Member

char0n commented Sep 27, 2021

@char0n sounds good, I have one unrelated question will there be a new petstore4.swagger.io site?

There is no plan currently. We'd like to merge release/4.x branch to master. SwaggerUI@4 stable release is about evolving our dependency tree in backward-incompatible way.

petstore2 and petstore3 are designated to serve OAS 2.x and OAS 3.0.x respectively. If we have support for OAS 3.1 well probably bootstrap new petstore31. The number suffix after petstore designates version of OAS spec that SwaggerUI is build with, rather then version of SwaggerUI. Does it make sense?

@tim-lai tim-lai merged commit 85597b9 into swagger-api:master Jan 18, 2022
@tim-lai
Copy link
Contributor

tim-lai commented Jan 18, 2022

@mathis-m circling back on this PR, which is now merged. Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

displayRequestDuration should be made available in react flavour of swagger-ui
3 participants