Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing swagger-ui-standalone-preset export #8906

Merged
merged 1 commit into from
Jun 11, 2023

Conversation

yue4u
Copy link
Contributor

@yue4u yue4u commented Jun 9, 2023

Description

close #8163

Motivation and Context

This issue requires client side to use patch-package or other workarounds. It'll be great if this can be fixed officially.

How Has This Been Tested?

given test.ts

import 'swagger-ui/dist/swagger-ui-standalone-preset'

before

# this will fail
$ esbuild test.ts --bundle
 > test.ts:1:7: error: Could not resolve "swagger-ui/dist/swagger-ui-standalone-preset" (mark it as external to exclude it from the bundle)
    1 │ import 'swagger-ui/dist/swagger-ui-standalone-preset'~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   node_modules/swagger-ui/package.json:6:13: note: The path "./dist/swagger-ui-standalone-preset" is not exported by package "swagger-ui"
    6 │   "exports": {
      ╵              ^

1 error

after

# this will success
$ esbuild test.ts --bundle

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@char0n char0n self-assigned this Jun 11, 2023
@char0n char0n added type: bug dependencies Pull requests that update a dependency file version: 4.x labels Jun 11, 2023
@char0n char0n merged commit cdd0bdd into swagger-api:master Jun 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file type: bug version: 4.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

StandalonePreset isn't exported in 4.14.0
2 participants