From ec0a62cbc5c9a20f02d1c558ff2708e7367922a9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Donny/=EA=B0=95=EB=8F=99=EC=9C=A4?= <kdy1997.dev@gmail.com>
Date: Fri, 4 Oct 2024 14:51:34 +0900
Subject: [PATCH] perf(es): Avoid needless string comparisons (#9613)

---
 .changeset/dull-carrots-smell.md                           | 7 +++++++
 crates/swc/src/builder.rs                                  | 1 -
 .../swc_ecma_transforms_base/src/rename/analyzer/scope.rs  | 6 +++---
 3 files changed, 10 insertions(+), 4 deletions(-)
 create mode 100644 .changeset/dull-carrots-smell.md

diff --git a/.changeset/dull-carrots-smell.md b/.changeset/dull-carrots-smell.md
new file mode 100644
index 000000000000..a68e6733aebc
--- /dev/null
+++ b/.changeset/dull-carrots-smell.md
@@ -0,0 +1,7 @@
+---
+swc: patch
+swc_core: patch
+swc_ecma_transforms_base: patch
+---
+
+perf(es): Avoid needless string comparisons
diff --git a/crates/swc/src/builder.rs b/crates/swc/src/builder.rs
index 6dbc76db89bf..cf91fc8fc4a3 100644
--- a/crates/swc/src/builder.rs
+++ b/crates/swc/src/builder.rs
@@ -337,7 +337,6 @@ impl<'a, 'b, P: swc_ecma_visit::Fold> PassBuilder<'a, 'b, P> {
                 modules::import_analysis::import_analyzer(import_interop, ignore_dynamic),
                 need_analyzer
             ),
-            compat::reserved_words::reserved_words(),
             Optional::new(
                 helpers::inject_helpers(self.unresolved_mark),
                 self.inject_helpers
diff --git a/crates/swc_ecma_transforms_base/src/rename/analyzer/scope.rs b/crates/swc_ecma_transforms_base/src/rename/analyzer/scope.rs
index 4d595124d2be..c613e7e047c9 100644
--- a/crates/swc_ecma_transforms_base/src/rename/analyzer/scope.rs
+++ b/crates/swc_ecma_transforms_base/src/rename/analyzer/scope.rs
@@ -8,7 +8,7 @@ use std::{
 #[cfg(feature = "concurrent-renamer")]
 use rayon::prelude::*;
 use rustc_hash::FxHashSet;
-use swc_atoms::Atom;
+use swc_atoms::{atom, Atom};
 use swc_common::{collections::AHashMap, util::take::Take, Mark, SyntaxContext};
 use swc_ecma_ast::*;
 use tracing::debug;
@@ -51,7 +51,7 @@ pub(super) struct ScopeData {
 
 impl Scope {
     pub(super) fn add_decl(&mut self, id: &Id, has_eval: bool, top_level_mark: Mark) {
-        if id.0 == "arguments" {
+        if id.0 == atom!("arguments") {
             return;
         }
 
@@ -73,7 +73,7 @@ impl Scope {
     }
 
     pub(super) fn add_usage(&mut self, id: Id) {
-        if id.0 == "arguments" {
+        if id.0 == atom!("arguments") {
             return;
         }