Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Do not index a string with a surrogate pair #9013

Merged
merged 3 commits into from
Jun 2, 2024
Merged

fix(es/minifier): Do not index a string with a surrogate pair #9013

merged 3 commits into from
Jun 2, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jun 2, 2024

@kdy1 kdy1 added this to the Planned milestone Jun 2, 2024
@kdy1 kdy1 self-assigned this Jun 2, 2024
@kdy1 kdy1 requested a review from a team as a code owner June 2, 2024 03:00
kodiakhq[bot]
kodiakhq bot previously approved these changes Jun 2, 2024
View reviewed changes
kdy1
kdy1 commented Jun 2, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_optimization
  • swc_core

@kdy1 kdy1 changed the title fix(es/minifier): Do not evaluate String[number] if it's surrogate fix(es/minifier): Do not index a string with a surrogate pair Jun 2, 2024
@kdy1 kdy1 enabled auto-merge (squash) June 2, 2024 03:01
swc-bot
swc-bot reviewed Jun 2, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 2879a4d into swc-project:main Jun 2, 2024
147 checks passed
@kdy1 kdy1 deleted the issue-9008 branch June 2, 2024 03:35
@kdy1 kdy1 modified the milestones: Planned, v1.5.25 Jun 5, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.5.25
Development

Successfully merging this pull request may close these issues.

minifier: invalid index access evaluation of string represented with surrogate pairs
2 participants
@kdy1 @swc-bot