swc_plugin_proxy-0.44.1 not compatible with swc_common-0.34.4

[Mad-Kat]

Describe the bug

I've created a new plugin with the swc cli and could not compile it afterwards.

error[E0308]: mismatched types
  --> .../index.crates.io-6f17d22bba15001f/swc_plugin_proxy-0.44.1/src/comments/plugin_comments_proxy.rs:87:48
   |
87 |             comments.add_leading_comments(pos, comments);
   |                      --------------------      ^^^^^^^^ expected `Vec<Comment>`, found `&Box<dyn Comments>`
   |                      |
   |                      arguments to this method are incorrect
   |
   = note: expected struct `Vec<Comment>`
           found reference `&Box<dyn Comments>`
note: method defined here
  --> .../index.crates.io-6f17d22bba15001f/swc_common-0.34.4/src/comments.rs:33:8
   |
33 |     fn add_leading_comments(&self, pos: BytePos, comments: Vec<Comment>);
   |        ^^^^^^^^^^^^^^^^^^^^

error[E0308]: mismatched types
   --> .../index.crates.io-6f17d22bba15001f/swc_plugin_proxy-0.44.1/src/comments/plugin_comments_proxy.rs:117:49
    |
117 |             comments.add_trailing_comments(pos, comments);
    |                      ---------------------      ^^^^^^^^ expected `Vec<Comment>`, found `&Box<dyn Comments>`
    |                      |
    |                      arguments to this method are incorrect
    |
    = note: expected struct `Vec<Comment>`
            found reference `&Box<dyn Comments>`
note: method defined here
   --> .../index.crates.io-6f17d22bba15001f/swc_common-0.34.4/src/comments.rs:40:8
    |
40  |     fn add_trailing_comments(&self, pos: BytePos, comments: Vec<Comment>);
    |        ^^^^^^^^^^^^^^^^^^^^^

Input code

No response

Config

No response

Playground link (or link to the minimal reproduction)

https://gist.github.com/Mad-Kat/de900587a273deda6753455fa4133867

SWC Info output

No response

Expected behavior

After setup a new plugin, it compiles and the tests run.

Actual behavior

No response

Version

swc_core: 0.96.7

Additional context

No response

[kdy1]

You can run cargo update -p swc_plugin_proxy to update it

[Mad-Kat]

Yes worked like a charm. Thank you so much for the speedy fix

[swc-bot]

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.