Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Fix variable declaration in default branch #9220

Merged
merged 3 commits into from
Jul 12, 2024
Merged

fix(es/minifier): Fix variable declaration in default branch #9220

merged 3 commits into from
Jul 12, 2024

Conversation

CPunisher
Copy link
Contributor

@CPunisher CPunisher commented Jul 12, 2024 •
edited by kdy1
Loading

Description:

When a default branch appears before an exact match, the variable declaration should be recorded before deleting the default branch.

Related issue:

@CPunisher CPunisher requested a review from a team as a code owner July 12, 2024 06:41
@kdy1 kdy1 self-assigned this Jul 12, 2024
@kdy1 kdy1 added this to the Planned milestone Jul 12, 2024
kdy1
kdy1 approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swc-bump:

  • swc_ecma_minifier
  • swc_core

@kdy1 kdy1 enabled auto-merge (squash) July 12, 2024 06:44
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 12, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9220 will not alter performance

Comparing CPunisher:fix/variable-declared-in-default (5faf7b6) with CPunisher:fix/variable-declared-in-default (6332923)

Summary

✅ 173 untouched benchmarks

⁉️ 1 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark CPunisher:fix/variable-declared-in-default CPunisher:fix/variable-declared-in-default Change
⁉️ es/full/base/resolver_and_hygiene 322.9 µs N/A N/A

swc-bot
swc-bot reviewed Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit a7c82bd into swc-project:main Jul 12, 2024
151 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.7.0 Jul 17, 2024
@Loonz806 Loonz806 mentioned this pull request Aug 8, 2024
Closed
@kdy1 kdy1 mentioned this pull request Aug 12, 2024
Merged
@Loonz806 Loonz806 mentioned this pull request Aug 15, 2024
Open
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

minifier: invalid handling for var variable declared in switch statement
3 participants
@CPunisher @kdy1 @swc-bot