Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/typescript): Workaround wasm-bindgen #9272

Merged
merged 1 commit into from
Jul 18, 2024
Merged

fix(es/typescript): Workaround wasm-bindgen #9272

merged 1 commit into from
Jul 18, 2024

Conversation

magic-akari
Copy link
Member

@magic-akari magic-akari commented Jul 18, 2024 •
edited
Loading

Note

We should remove this if rustwasm/wasm-bindgen#4015 get mereged.

@magic-akari magic-akari requested a review from a team as a code owner July 18, 2024 02:30
kdy1
kdy1 approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swc-bump:

  • dbg-swc

@kdy1 kdy1 changed the title fix(es/typescript): patch for wasm-bindgen fix(es/typescript): Workaround wasm-bindgen Jul 18, 2024
@kdy1 kdy1 enabled auto-merge (squash) July 18, 2024 02:31
@kdy1 kdy1 added this to the Planned milestone Jul 18, 2024
@kdy1 kdy1 disabled auto-merge July 18, 2024 02:39
@kdy1 kdy1 merged commit 6b1d2ff into main Jul 18, 2024
154 checks passed
@kdy1 kdy1 deleted the fix/wasm/endianness branch July 18, 2024 02:39
@kdy1 kdy1 modified the milestones: Planned, v1.7.0 Jul 18, 2024
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 18, 2024

CodSpeed Performance Report

Merging #9272 will not alter performance

Comparing fix/wasm/endianness (b5475d5) with main (93d9e44)

Summary

✅ 178 untouched benchmarks

@Loonz806 Loonz806 mentioned this pull request Aug 8, 2024
Closed
@kdy1 kdy1 mentioned this pull request Aug 12, 2024
Merged
@Loonz806 Loonz806 mentioned this pull request Aug 15, 2024
Open
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@magic-akari @kdy1