Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/typescript): Strip exported default overload function declaration #9412

Merged

Conversation

magic-akari
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

@magic-akari magic-akari requested a review from a team as a code owner August 9, 2024 16:02
Copy link

changeset-bot bot commented Aug 9, 2024

🦋 Changeset detected

Latest commit: 72ed02f

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 added this to the Planned milestone Aug 9, 2024
@magic-akari magic-akari force-pushed the type-strip/export-default-overload branch from 1d8ef4e to 72ed02f Compare August 9, 2024 17:11
@magic-akari magic-akari enabled auto-merge (squash) August 9, 2024 17:39
@kdy1 kdy1 disabled auto-merge August 9, 2024 17:41
@kdy1 kdy1 merged commit b395f48 into swc-project:main Aug 9, 2024
152 of 154 checks passed
Copy link

codspeed-hq bot commented Aug 9, 2024

CodSpeed Performance Report

Merging #9412 will improve performances by 5.28%

Comparing magic-akari:type-strip/export-default-overload (72ed02f) with main (8c161a0)

Summary

⚡ 2 improvements
✅ 176 untouched benchmarks

Benchmarks breakdown

Benchmark main magic-akari:type-strip/export-default-overload Change
es/full/bugs-1 567.9 µs 539.4 µs +5.28%
common/allocator/alloc/cached-no-scope/1000000 115.5 ms 111.4 ms +3.64%

@kdy1 kdy1 modified the milestones: Planned, v1.7.10 Aug 9, 2024
@magic-akari magic-akari deleted the type-strip/export-default-overload branch August 10, 2024 07:47
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants