Estimate MRelative based on NetworkMagnitude
#121
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damb
added
magnitude
|
👍 I think it is ok. |
|
@damb Question: When I compile this branch I still get the bug regarding phase association. Do you think it is necessary to remove it? |
|
I rebased the branch. The most recent changes from master should be available, now. |
added 7 commits
August 23, 2022 06:18
Estimating `MRelative` based on the *NetworkMagnitude* (i.e. the preferred event magnitude) by default. Optionally, `MRelative` still may be estimated based on the StationMagnitude. Wether to use the NetworkMagnitude or the StationMagnitude may be defined in the bindings configuration (as a consequence, this parameter is configurable on sensor location granularity). Note that for estimating `MRelative` based on the NetworkMagnitude requires both the Event and the Origin including the preferred event magnitude to be available in the EventParameters data. Besides, with this commit the sensor location identifiers referencing StationMagnitudes (at `magnitude::Factory`) include the band and source code.
Note that from now on the default uses the NetworkMagnitude when estimating `MRelative`.
|
@damb Vielen Dank! ❤️🔥 |
|
@mmesim, I don't plan to make further changes here. Feel free to rebase/edit this feature branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mmesim, here a draft implementation for #118.
Features and Changes:
MRelativebased on the preferredDataModel::Eventmagnitude i.e. the NetworkMagnitude. Alternatively, the estimation may be still performed based on the StationMagnitude. Note that this requires both the Event and the Origin including the preferred magnitude to be available within the EventParameters.Closes #118.