Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Render node exists without concomitant env" in 1.13.4 #76

Closed
thec0keman opened this issue Jul 14, 2015 · 3 comments
Closed

"Render node exists without concomitant env" in 1.13.4 #76

thec0keman opened this issue Jul 14, 2015 · 3 comments

Comments

@thec0keman
Copy link

When upgrading from Ember 1.13.3 -> 1.13.4 we have several tests that are now failing with the error Uncaught Error: Assertion Failed: BUG: Render node exists without concomitant env. .

At least one example of a failing scenario would be with a template like:

{{#if savedOption}}
  <button {{action "removeOption" on="click"}}></button>
{{else}}
  {{input value=inputValue}}
{{/if}}

(where the action simply nullifies savedOption)

with the following component integration test:

test('you can click an thing and it disappears', function(assert) {
  var component = this.subject();

  component.setProperties({
    savedOption: { id: 5, name: 'Thing '},
  });

  this.$();
  this.$('button').click();

  assert.notExists(this.$('button'), 'The thing disappears');
});

And the exception is raised.

Further, this can have the side effect of not tearing down the test correctly, so that the following test raises a Assertion Failed: You cannot use the same root element (#ember-testing) multiple times.

An example repo is here:
https://github.com/thec0keman/action-input-bug

This is using Ember QUnit 0.4.1.

@thec0keman thec0keman changed the title Issue with 1.13.4 "Render node exists without concomitant env" in 1.13.4 Jul 14, 2015
@thec0keman
Copy link
Author

I'm not sure if this is very helpful, but the tests start failing after #5c6b627 commit.

@thec0keman
Copy link
Author

After further testing, this is appearing in both integration and unit component tests. I'm also seeing the same failures in 2.0.0-beta2.

It looks like there is some issue with the teardown of the view in the if block, but I am very unfamiliar with the internals of Ember / HTMLBars on this point. @rwjblue would you have any suggestions for further steps to better diagnose this?

@thec0keman
Copy link
Author

This is now working in 0.5.2, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant