Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command/Meta/Windows key in keybindings #1065

Closed
1 task
mskvsk opened this issue May 20, 2024 · 3 comments · Fixed by #1069
Closed
1 task

Command/Meta/Windows key in keybindings #1065

mskvsk opened this issue May 20, 2024 · 3 comments · Fixed by #1069
Labels
feature New feature request

Comments

@mskvsk
Copy link
Contributor

mskvsk commented May 20, 2024

Please describe the problem you're trying to solve

Currently, there is no way to use the Command/Meta/Windows key in keybindings. While it is possible to go without Meta/WIndows on Linux and WIndows, the Command key is central to the macOS workflow.

Would you be willing to contribute this feature?

  • Yes, I'll give it a shot

Describe the solution you'd like

Neovim has implemented a D- notation (e.g. D-A) to support that key because more obvious choices are already taken by Control (C) and Alt/Option (M).

So, I would suggest to use that notation as well.

Additional context

As far as I understand, Kitty Terminal has something that resembles a standard on how to send key codes including the ones that use the Meta key. At least, the D- notation in Neovim works with Kitty out of the box and enabling this protocol is recommended by the creator of Wez's Terminal as the solution to the issue.

Also, this issue could be helpful as well.

@sxyazi
Copy link
Owner

sxyazi commented May 21, 2024

Please try #1069

@sxyazi sxyazi added the waiting on op Waiting for more information from the original poster label May 21, 2024
@mskvsk
Copy link
Contributor Author

mskvsk commented May 21, 2024

Please try #1069

Works like a charm, ready to merge. Thank you!

@github-actions github-actions bot removed the waiting on op Waiting for more information from the original poster label May 21, 2024
Copy link

I'm going to lock this issue because it has been closed for 30 days. ⏳
This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants