Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to turn off selection cursor blink in input #1101

Closed
1 task
dangooddd opened this issue May 29, 2024 · 10 comments · Fixed by #1139
Closed
1 task

Add option to turn off selection cursor blink in input #1101

dangooddd opened this issue May 29, 2024 · 10 comments · Fixed by #1139
Assignees
Labels
feature New feature request

Comments

@dangooddd
Copy link

dangooddd commented May 29, 2024

Please describe the problem you're trying to solve

Search, find and other popups got cursor blink (or some sort of animation). I thought that it can be changed in theme.toml [input] -> selected field, but changing anything here does nothing to ui.

Would you be willing to contribute this feature?

  • Yes, I'll give it a shot

Describe the solution you'd like

Add option to theme.toml that turn off cursor blink animation.
If it exist, add some guidelines for it in documentation

Additional context

No response

@dangooddd dangooddd added the feature New feature request label May 29, 2024
@dangooddd dangooddd changed the title Add option to remove selection cursor blink in input Add option to turn off selection cursor blink in input May 29, 2024
@dangooddd
Copy link
Author

I figured out what selected field in theme.toml does, and it don't change cursor behavior

@sxyazi
Copy link
Owner

sxyazi commented May 29, 2024

I don't quite understand what you mean, can you record a gif?

@sxyazi sxyazi added the waiting on op Waiting for more information from the original poster label May 29, 2024
@dangooddd
Copy link
Author

dangooddd commented May 29, 2024

blink
Sorry, hope here you understand! (in find popup there is cursor animation, quality is bad but in reality animation faster ofc).

@github-actions github-actions bot removed the waiting on op Waiting for more information from the original poster label May 29, 2024
@sxyazi
Copy link
Owner

sxyazi commented May 29, 2024

I see, but Yazi doesn’t add a blinking to the cursor. I think it largely depends on your terminal style/config - what terminal are you using? Is it the same with other terminals?

My terminal (kitty) looks like :

screenshot-000096.mp4

@dangooddd
Copy link
Author

idk why, but wezterm draws blinking cursor in all yazi's input popups. But disabling blinking globally is not a great solution. Can it be changed in other way?

@dangooddd
Copy link
Author

And also, it seems like you also got some sort of blink, or i misunderstand it

@dangooddd
Copy link
Author

dangooddd commented May 29, 2024

foot_blink.mp4

Checked out foot, also got blinking in input fields. I mean is there a way to make cursor in input field completely constant? Maybe add settings group for cursor in theme.toml (it will be nice!) ?

@og900aero
Copy link

foot_blink.mp4
Checked out foot, also got blinking in input fields. I mean is there a way to make cursor in input field completely constant? Maybe add settings group for cursor in theme.toml (it will be nice!) ?

It is terminal "problem"/config. I'm on Debian 12 stable and I try with any terminal, but doesnt blink:

  • alacritty
  • st
  • kitty
  • xterm
  • urxvt

@dangooddd
Copy link
Author

@og900aero i got cursor blink in kitty too... (zero config)

kitty_blink.mp4

Copy link

github-actions bot commented Jul 9, 2024

I'm going to lock this issue because it has been closed for 30 days. ⏳
This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature request
Projects
None yet
3 participants