Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iTerm2 image protocol for vscode #756

Closed
1 task
jerch opened this issue Mar 1, 2024 · 3 comments
Closed
1 task

iTerm2 image protocol for vscode #756

jerch opened this issue Mar 1, 2024 · 3 comments
Labels
feature New feature request

Comments

@jerch
Copy link

jerch commented Mar 1, 2024

Please describe the problem you're trying to solve

Is there a specific reason why you use Sixel for vscode terminal? Wouldn't the iterm protocol give higher quality output and be faster to process?

Would you be willing to contribute this feature?

  • Yes, I'll give it a shot

Describe the solution you'd like

--- a/yazi-adaptor/src/adaptor.rs
+++ b/yazi-adaptor/src/adaptor.rs
@@ -92,9 +92,9 @@ impl Adaptor {
                        Emulator::Foot => vec![Self::Sixel],
                        Emulator::Ghostty => vec![Self::KittyOld],
                        Emulator::BlackBox => vec![Self::Sixel],
-                       Emulator::VSCode => vec![Self::Sixel],
-                       Emulator::Tabby => vec![Self::Sixel],
-                       Emulator::Hyper => vec![Self::Sixel],
+                       Emulator::VSCode => vec![Self::Iterm2],
+                       Emulator::Tabby => vec![Self::Iterm2],
+                       Emulator::Hyper => vec![Self::Iterm2],
                        Emulator::Mintty => vec![Self::Iterm2],
                        Emulator::Neovim => vec![],
                };

Additional context

Resizing is not yet working, but I think you already got that covered upstream in crossterm-rs/crossterm#810.

@jerch jerch added the feature New feature request label Mar 1, 2024
@sxyazi
Copy link
Owner

sxyazi commented Mar 1, 2024

😲 Interesting, I just found out that they support the iTerm2 protocol...

I will test them and create a commit to switch to IIP, thank you for letting me know this.

@sxyazi
Copy link
Owner

sxyazi commented Mar 1, 2024

Done in c3a1103 and yazi-rs/yazi-rs.github.io@d4249f1

@sxyazi sxyazi closed this as completed Mar 1, 2024
Copy link

I'm going to lock this issue because it has been closed for 30 days. ⏳ This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature New feature request
Projects
None yet
Development

No branches or pull requests

2 participants