fix(reactivity-transform): don't wrap empty defaults

vue-macros · Jul 15, 2023 · 4df51da · 4df51da
1 parent 71660f0
commit 4df51da
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 14 deletions.
diff --git a/.changeset/dull-pumpkins-change.md b/.changeset/dull-pumpkins-change.md
@@ -0,0 +1,5 @@
+---
+'@vue-macros/reactivity-transform': patch
+---
+
+don't wrap empty defaults
diff --git a/packages/reactivity-transform/src/core/sfc.ts b/packages/reactivity-transform/src/core/sfc.ts
@@ -143,17 +143,21 @@ const ${
         { offset }
       )
     } else if (defineDecl.arguments[0]) {
-      s.overwriteNode(
-        node,
-        `defineProps(${importHelperFn(
-          s,
-          offset,
-          'mergeDefaults'
-        )}(${s.sliceNode(defineDecl.arguments[0], {
-          offset,
-        })}, { ${defaultStr} }))`,
-        { offset }
-      )
+      if (defaultStr) {
+        s.overwriteNode(
+          node,
+          `defineProps(${importHelperFn(
+            s,
+            offset,
+            'mergeDefaults'
+          )}(${s.sliceNode(defineDecl.arguments[0], {
+            offset,
+          })}, { ${defaultStr} }))`,
+          { offset }
+        )
+      } else {
+        s.overwriteNode(node, s.sliceNode(defineDecl, { offset }), { offset })
+      }
     } else
       throw new SyntaxError(
         `${DEFINE_PROPS}() must have at least one argument or type argument.`

diff --git a/packages/reactivity-transform/tests/__snapshots__/fixtures.test.ts.snap b/packages/reactivity-transform/tests/__snapshots__/fixtures.test.ts.snap
@@ -118,15 +118,15 @@ export { scriptAndSetup as default };
 `;
 
 exports[`fixtures > tests/fixtures/vue3/alias.vue 1`] = `
-"import { mergeDefaults, toRef, toDisplayString } from 'vue';
+"import { toRef, toDisplayString } from 'vue';
 import _export_sfc from '[NULL]/plugin-vue/export-helper';
 
 const _sfc_main = {
   __name: 'alias',
-  props: mergeDefaults({
+  props: {
   foo: String,
   baz: Number,
-}, {  }),
+},
   setup(__props) {
 const propAlias2 = toRef(__props, \\"baz\\");
 const propAlias = toRef(__props, \\"foo\\");