"View on Tumblr" links should go to blog's domain/subdomain if possible

[the-blank-x]

There are three types of blogs:

• Those with a domain (has a custom theme): https://www.omocat-blog.com (Tumblr name: omocat)
• Those with a subdomain (has a custom theme): https://prettiestplatypus.tumblr.com
• Those without a subdomain or domain (does not have a custom theme): https://www.tumblr.com/brooke2valley

I prefer browsing blogs with their custom theme over using Priviblur (which I prefer over using the crappy interface at www.tumblr.com), so when I land on a new blog while on Priviblur, I try to navigate to https://<blog>.tumblr.com to see if it has a custom theme. However, Priviblur's "View on Tumblr" links points to the subdomain/domain-less versions.

I've already made Priviblur use the domain or subdomain versions here, but I'm making this issue first to see if this would be accepted upstream.

[syeopite]

Sounds good to me though I'm against this being the default behavior. Feel free to make a PR once settings are added, which should hopefully be before the end of the month if nothing goes wrong.

[the-blank-x]

Sure, though I wonder if you could let instances pick their default settings (akin to Nitter)

[syeopite]

Yeah instances will definitely be able to configure the default settings.

[syeopite]

I do wonder if there are any security risks to users for Priviblur directly linking (which can be taken as endorsing) to a blog's subdomain considering that there have been a few cases in the past where blogs were using malicious scripts within their custom themes.

Those are usually caught pretty quickly by Tumblr but it is still a risk factor that exists for custom themes but not with Tumblr's dashboard layout.

[the-blank-x]

Possibly. I'm willing to take that risk though.