Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No release in a long time #1046

Closed
trishume opened this issue Apr 3, 2015 · 7 comments
Closed

No release in a long time #1046

trishume opened this issue Apr 3, 2015 · 7 comments

Comments

@trishume
Copy link
Contributor

trishume commented Apr 3, 2015

As you know, this is the longest time Spacemacs has ever gone between releases.
This wouldn't be a problem except there are lots of problems with master that have been fixed in develop which necessitates people switching who otherwise don't want bleading edge.

Recently 769d54d was committed to develop which is a big cool new feature but will require lots of work to get stable and working everywhere it should. So now we have a bunch of people forced to use a branch where lots of things aren't working that used to (e.g #1045).

Previous to that commit develop was actually quite stable so I recommend that 2905190 be merged as a new release, possibly using a git-flow release branch to fix up some things. That way we'll have a nice stable master and less time pressure to get the new auto-complete working smoothly.
@trishume
Copy link
Contributor Author

trishume commented Apr 3, 2015

This may also give us time to add a Changelog feature which will be useful since auto-completion layer not being default and the company-mode layer being gone will be a breaking change for almost every singe user of Spacemacs. Might reduce the inevitable hundreds of Gitter questions about auto-complete and company being "broken".

trishume referenced this issue Apr 3, 2015
@syl20bnr
New layer auto-completion
769d54d 
Move company and auto-complete to a common layer.
They are not enabled globally anymore, each mode using them
must explicitly declare a hook.
Only one frontend is supported for a given mode, we have to
choose the best between the two.
Only one key binding to toggle auto-completion on `SPC t a` no
matter if it is company or auto-complete. The lighter in the
mode-line is Ⓐ for both frontends.
@syl20bnr
Copy link
Owner

syl20bnr commented Apr 4, 2015

I will release all at once with an explicit message on the startup screen. Like magit did for version 1.4.

@CarlQLange CarlQLange mentioned this issue Apr 4, 2015
Closed
@PierreR
Copy link
Contributor

PierreR commented Apr 5, 2015

As a note, I have just switched to develop and the completion does not seem to work in haskell file. I do get the Ⓐ but completion never pops up anymore (I did change company-mode for auto-completion in my .spacemacs)

@trishume
Copy link
Contributor Author

trishume commented Apr 5, 2015

@PierreR not surprising, I'm going to try and take a look at a lot of modes soon. Post it in #1045, this issue is on a different topic.

@PierreR PierreR mentioned this issue Apr 5, 2015
Closed
6 tasks
@trishume trishume mentioned this issue Apr 6, 2015
Merged
@syl20bnr
Copy link
Owner

syl20bnr commented Apr 7, 2015

jk ;-D

@trishume
Copy link
Contributor Author

trishume commented Apr 7, 2015

lol

@trishume
Copy link
Contributor Author

woot! 🎊 🎆 ✨ 🎇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PierreR @trishume @syl20bnr