Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.103: getting diff-hl in the margin also in a GUI setup #2180

Closed
emmanueltouzery opened this issue Jul 2, 2015 · 3 comments
Closed

0.103: getting diff-hl in the margin also in a GUI setup #2180

emmanueltouzery opened this issue Jul 2, 2015 · 3 comments

Comments

@emmanueltouzery
Copy link
Contributor

since 0.103 version-control uses diff-hl not anymore git-gutter.
in my .spacemacs I put:

  (setq diff-hl-side 'left)

same as I had left-fringe for git-gutter. But I doubt it has anything to do with my problem. The problem is that when just starting emacs diff-hl displays in the fringe as expected. However if I start it with emacsclient -c "$@" --alternate-editor= & then I get diff-hl consistently in the margin instead of the fringe.

if I comment these lines in the version-control layer then it's again all ok:

(unless (display-graphic-p)
   (setq diff-hl-side 'left)
   (diff-hl-margin-mode))

it looks like emacsclient somehow triggers display-graphic-p to be false. I attempted changing the condition to window-system instead of display-graphic-p but the problem remains.

@emmanueltouzery
Copy link
Contributor Author

now added (diff-hl-margin-mode 0) in my .spacemacs as a workaround.

@emmanueltouzery
Copy link
Contributor Author

this might be related to this: http://stackoverflow.com/a/5801740/516188

You can start emacs in daemon mode, then later tell it to create a graphical frame. [..]
As a result of this, avoid putting code in your .emacs that depends on window-system. Instead, put code like your set-frame-size example in a hook function which runs after a frame is created

@d12frosted
Copy link
Collaborator

Fixed with released of Spacemacs v0.200. Let us know if you still have any problems with this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants