Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] gh doesn't work in OrgMode files when Spacemacs freshly opened #2615

Closed
swaroopch opened this issue Aug 11, 2015 · 9 comments
Closed

Comments

@swaroopch
Copy link
Contributor

As of 350f809 in develop branch:

  1. Exit and Open Spacemacs again
  2. Navigate to an OrgMode file
  3. Press gh - it says g h is undefined
  4. Press i (get into insert mode) and Esc (back into normal mode)
  5. Press gh - now works as expected
@robbyoconnor
Copy link
Contributor

I would look to see if any commits introduced after that introduced this regression...

@TheBB
Copy link
Collaborator

TheBB commented Sep 14, 2015

Is this still an issue? I can't reproduce. The org layer is enabled, right?

@swaroopch
Copy link
Contributor Author

Still happens for me. Yes, org layer is enabled.

System Info

  • OS: darwin
  • Emacs: 24.5.1
  • Spacemacs: 0.104.0
  • Spacemacs branch: develop (rev. 21146f4)
  • Distribution: spacemacs
  • Layers:
(emacs-lisp org)

@moesasji
Copy link

@TheBB: Bug is present for me on 0.104.4 as well, so this one can be reproduced for the current stable release.

Note that this PR might be related to #3596 (same way to reproduce and also mention gh)

System Info

  • OS: gnu/linux
  • Emacs: 24.5.1
  • Spacemacs: 0.104.4
  • Spacemacs branch: master (rev. f04bb61)
  • Distribution: spacemacs
  • Layers:
(auto-completion emacs-lisp latex org
                 (shell :variables shell-default-height 30 shell-default-position 'bottom)
                 syntax-checking)

@TheBB
Copy link
Collaborator

TheBB commented Nov 11, 2015

Thanks for pointing that issue out. Since it's older I will close this as a duplicate, let's move the discussion there.

This is a strange error, but I still can't repro it.

@TheBB TheBB closed this as completed Nov 11, 2015
@TheBB TheBB reopened this Nov 11, 2015
@TheBB
Copy link
Collaborator

TheBB commented Nov 11, 2015

Sorry, this one is the older one. :-D

@moesasji
Copy link

I switched to the development branch to check and on the develop I can't reproduce this issue. So it looks like this issue might be fixed on develop, while it is a valid bug for the 0.104 branch.

btw) Shocking how much smoother/faster develop is compared to stable

System Info

  • OS: gnu/linux
  • Emacs: 24.5.1
  • Spacemacs: 0.105.0
  • Spacemacs branch: develop (rev. 9e5e309)
  • Distribution: spacemacs
  • Layers:
(auto-completion emacs-lisp latex org
                 (shell :variables shell-default-height 30 shell-default-position 'bottom)
                 syntax-checking)

@TheBB
Copy link
Collaborator

TheBB commented Nov 11, 2015

That's good. If you feel so inclined you can bisect to find out when it was fixed. I'm guessing it was in 48edef1.

Since it sounded like it was very easily reproduced on master, I believe it's fixed so I will label it as such.

@swaroopch
Copy link
Contributor Author

I can confirm that this is fixed in develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants