Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salt layer <enter> key binding #3369

Closed
numkem opened this issue Oct 13, 2015 · 7 comments
Closed

Salt layer <enter> key binding #3369

numkem opened this issue Oct 13, 2015 · 7 comments

Comments

@numkem
Copy link

numkem commented Oct 13, 2015

With the release of 0.104, the salt layer was changed to use salt-mode.

The keybinding for the standard enter key has been changed to do a line return and indent by one. While this would work with blocks of codes it doesn't work at all when I just want to add empty lines.

I understand I should probably go back to normal mode and do something like 2o to insert 2 lines but I feel that is a pretty big step for just inserting empty lines.

Is there a way to change this in the layer itself or at least point me to how to change a keybinding in a mode.

Thank you.

@TheBB
Copy link
Collaborator

TheBB commented Oct 16, 2015

I can't reproduce this. I don't know anything about salt files, but I can hit return as much as I like with no issues. Is there some specific file I can test?

@numkem
Copy link
Author

numkem commented Oct 16, 2015

Files needs to finish by .sls and they are in a yaml format.

Examples here

@StreakyCobra
Copy link
Contributor

I managed to reproduce it and indeed it seems to be an annoying behaviour. Sadly I don't know anything about salt. Pinging the salt-layer's author in case he can help: @beardedprojamz :-)

@deybhayden
Copy link
Contributor

https://github.com/beardedprojamz/salt-mode - I'm happy to accept pull requests - but not currently using spacemacs for my everyday stuff - or writing enough salt to be annoyed. 😛 It'd probably be something in how the mmm-mode works with the jinja stuff. I definitely doubt it's a spacemacs issue, as the layer just turns the mode on. But, you could also test salt-mode directly with vanilla emacs too.

@StreakyCobra
Copy link
Contributor

Thanks for the information @beardedprojamz. I didn't knew you weren't using Spacemacs anymore, sorry for bothering you 😄

@numkem It seems to be an upstream issue, so you can report it there (and contribute maybe 😉 ). That said I think we can close this issue 😄

@deybhayden
Copy link
Contributor

I'm pretty flakey, so I might wrap back around at some point. 😉 But definitely a responsive maintainer and will merge any fixes 👍

@StreakyCobra
Copy link
Contributor

As it's finally not a spacemacs bug, I'll close this one. All information are there if somebody want to go further with this bug (i.e. contributing upstream ☺️)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants