Fix error in latitude grouping when creating a unique postcode index #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple modification at line 254 that should solve issue symerio#32 and issue symerio#55. latitude was misspelled as "lattitude". With this misspelling the field latitude *does* figure in the valid_keys list and thus the average value of the latitude will be overwritten in line 260 with the first value seen in the source database and thus the coordinates are slightly shifted.
rth
reviewed
Jun 16, 2022
There was a problem hiding this comment.
Thanks a lot @hedi-guedidi ! Could you please add non-regression unit test (a test that failed before this fix)? Thanks!
rth
changed the title
rth
changed the title
for more information, see https://pre-commit.ci
|
Thanks for addressing this @hedi-guedidi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple modification at line L254 that should solve issue #32 and issue #55. latitude was misspelled as "lattitude". With this misspelling the field latitude does figure in the valid_keys list and thus the average value of the latitude will be overwritten in line L260 with the first value seen in the source database and thus the coordinates are slightly shifted.
Closes #32
Closes #55