Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is Symfony\Component\Panther\ServerExtension PHPUnit 10 compatible? #586

Closed
arderyp opened this issue Feb 17, 2023 · 3 comments
Closed

is Symfony\Component\Panther\ServerExtension PHPUnit 10 compatible? #586

arderyp opened this issue Feb 17, 2023 · 3 comments

Comments

@arderyp
Copy link
Contributor

arderyp commented Feb 17, 2023

I know this package depends on symfony/phpunit-bridge, which is not yet PHPUnit 10 compatible. But, once it is, will Symfony\Component\Panther\ServerExtension be ready?

@arderyp
Copy link
Contributor Author

arderyp commented Feb 18, 2023

It appears to be still using the Hook-based extension system, which is deprecated. Here is a great writeup about thew new Event system in phpunit 10 with examples for how to implement it: https://localheinz.com/articles/2023/02/14/extending-phpunit-with-its-new-event-system/

there are other deprecations that need to be addressed for 9-to-10 migration, but most of them are simple patterns that can be done easily with Rector's phpunit 10 migration (or manually). But the extension migration requires a decent amount of work/thinking/refactoring.

@wouterj
Copy link
Member

wouterj commented Feb 18, 2023

But, once it is, will Symfony\Component\Panther\ServerExtension be ready?

If someone contributes the necessary changes, I'm sure it will be :)

@arderyp
Copy link
Contributor Author

arderyp commented Feb 22, 2023

the answer is no.

I opened a new issue for the task: #588

@arderyp arderyp closed this as completed Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants