Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yarn upgrade] unmet peer dependency "webpack@^5.0.0" #1145

Closed
arderyp opened this issue Aug 11, 2022 · 6 comments
Closed

[yarn upgrade] unmet peer dependency "webpack@^5.0.0" #1145

arderyp opened this issue Aug 11, 2022 · 6 comments

Comments

@arderyp
Copy link

arderyp commented Aug 11, 2022

$ yarn upgrade
yarn upgrade v1.22.19
...
warning " > file-loader@6.2.0" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0".
warning " > sass-loader@13.0.2" has unmet peer dependency "webpack@^5.0.0".
warning " > ts-loader@9.3.1" has unmet peer dependency "webpack@^5.0.0".

doing yarn add webpack@^5.0.0 resolved those warnings but produces a new warning during encore build:

$ yarn encore production
yarn run v1.22.19
...

 WARNING  Webpack is already provided by Webpack Encore, also adding it to your package.json file may cause issues.
 DONE  Compiled successfully in 23703ms 

Is this something to be concerned about or to address?

@Kocal
Copy link
Member

Kocal commented Aug 11, 2022

See #1142

@arderyp
Copy link
Author

arderyp commented Aug 11, 2022

Thanks @Kocal, should I close this?

@Kocal
Copy link
Member

Kocal commented Aug 11, 2022

Until the PR is not merged, I don't think so

@arderyp
Copy link
Author

arderyp commented Aug 11, 2022

@Kocal do you think that PR will resolve this? If so, does it require changing something in my packages.json?

@Kocal
Copy link
Member

Kocal commented Aug 11, 2022

Yeah it will resolves the issue since you will be required to install webpack by yourself (and so update your package.json)

@Kocal
Copy link
Member

Kocal commented Sep 18, 2022

Can be closed since Encore v4.

@stof stof closed this as completed Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants