Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static_content directory structure #220

Closed
xavierba opened this issue Mar 2, 2018 · 0 comments
Closed

static_content directory structure #220

xavierba opened this issue Mar 2, 2018 · 0 comments

Comments

@xavierba
Copy link
Contributor

xavierba commented Mar 2, 2018

Hi,

The static_content directory structure is currently as follow (modified for readability):
.
├── external
│   ├── font-awesome
│   │   ├── css
│   │   └── fonts
│   ├── foundation
│   │   ├── css
│   │   └── js
│   ├── html5shiv
│   ├── images (this is the jquery-ui smoothness theme)
│   ├── jqplot.js
│   ├── jquery.js
│   ├── jquery-migrate.js
│   ├── jquery-ui.js
│   ├── modernizr.custom.js
│   └── respondjs
├── fonts
│   ├── foundation-icons
│   └── Raleway
├── icons
└── js
  └── sympa.js

The external directory name probably comes from the fact it's all bundled code.
The foundation-icons and raleway fonts are thus mislocated and should be moved into external.
That would left only icons (which origin is unsure) and sympa.js outside of external and thus makes me wonder if moving the fonts inside external is the right thing to do.
(On a side note sympa.js is clearly sympa code, but is missing a copyright header.)

Another directory structure could then be something like this:
.
├── fonts
│   ├── font-awesome
│   ├── foundation-icons
│   └── Raleway
├── icons
└── js
├── foundation
├── html5shiv
├── jqplot
├── jquery
├── jquery-migrate
├── jquery-ui
├── modernizr
├── respondjs
└── sympa

As @ikedas is working on upgrading to foundation6 (#170 ) and other related JS work, it might be a good time to discuss this.

On an unrelated note, distros are usually not fond of bundled code and usually unbundle it when possible. I'd like to discuss a mechanism to allow for simplify this unbundling work, maybe by allowing to specify the path for the system-provided javascripts and fonts at configure time and only install bundled code if not specified (which would be the default case indeed).
This is probably better discussed in a separate issue, but might influence the way to resolve this issue.

Regards,
Xavier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants