Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid "subscribe spam" #302

Closed
ldidry opened this issue May 15, 2018 · 7 comments
Closed

Avoid "subscribe spam" #302

ldidry opened this issue May 15, 2018 · 7 comments
Labels
Milestone

Comments

@ldidry
Copy link
Contributor

ldidry commented May 15, 2018

  • if the subscriber is already is the subscription to moderate list, Sympa should not send a new mail to moderators
  • if the subscriber is in the blacklist, no mail shoud be sent either.

We had the case where someone in the blacklist send subscription mails again and again, and the moderator got mail notification again and again.

Seen on 6.2.16

@ldidry ldidry added the bug label May 15, 2018
@ikedas
Copy link
Member

ikedas commented May 16, 2018

Hi @ldidry,

Can you show us configuration of your Sympa, especially things below?

  • subscribe parameter in list config
  • use_blacklist parameter in sympa.conf or (if any) robot.conf

@ldidry
Copy link
Contributor Author

ldidry commented May 16, 2018

The list config:

config.0:subscribe owner

sympa.conf:

use_blacklist   send,create_list

Ok, I see now that sympa.conf should use subscribe as well, is it that?

What are the valid values for use_blacklist? I'll add them to the documentation.

@ikedas
Copy link
Member

ikedas commented May 16, 2018

Ok, I see now that sympa.conf should use subscribe as well, is it that?
What are the valid values for use_blacklist? I'll add them to the documentation.

Yes, in the second case you reported, you may have to add subscribe to the value of use_blacklist parameter. If the problem disappeared by this change, the second case is not a bug.

I'll investigate the first case further.

@ikedas
Copy link
Member

ikedas commented May 28, 2018

Hi @ldidry,
About the firset case:

  • if the subscriber is already is the subscription to moderate list, Sympa should not send a new mail to moderators

Please show us:

  • Configuration of the list in question.
  • Procedure to reproduce problem.

Thanks.

@ikedas
Copy link
Member

ikedas commented Aug 12, 2018

Hi @ldidry,

With PR #390, I think the first case will never occur, because, for example in subscribe.auth scenario:

# subscribe.auth
title.gettext subscription request confirmed

!equal([sender],[email])           smtp,dkim,md5,smime -> request_auth([email])
is_subscriber([listname],[email])  smtp,dkim,md5,smime -> do_it
true()                             smtp,dkim           -> request_auth([email])
true()                             md5,smime           -> do_it

If the user has already subscribed, do_it is returned, and subscribe request will fail with a response "The User '...' is already subscriber of list '...'."

@ldidry
Copy link
Contributor Author

ldidry commented Aug 12, 2018

Please show us:

Configuration of the list in question.
Procedure to reproduce problem.

Sorry, I didn't see the message. And now, I don't remember which list it was.

Glad to see that #390 will solve the case.

I'll test the case once I updated our Sympa and applied the patch (in two days)

@ikedas ikedas added this to the 6.2.36 milestone Aug 25, 2018
@ikedas
Copy link
Member

ikedas commented Sep 4, 2018

Solved. Thanks for reporting bug! Closing.

@ikedas ikedas closed this as completed Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants