Database membership updates now fail silently if there is an error

[skunktoy]

sympa-6.2.48 on SLES 12.4

I have noticed that if you write a bad query and try to manually force a membership update through the web interface it now fails silently instead of putting up and error like it used to. Curious if this this new expected behavior?

Thanks!

[skunktoy]

An example error from the sympa.log file :

2019-11-05T09:34:21.826152-05:00 boxname wwsympa[4249]: err main::#1544 > main::do_sync_include#16517 > Sympa::List::sync_include#4828 > Sympa::Spindle::spin#95 > Sympa::Request::Handler::include::_twist#181 > Sympa::Request::Handler::include::_update_users#289 > Sympa::DataSource::open#134 > Sympa::DataSource::SQL::_open#99 > Sympa::Process::eval_in_time#472 > (eval)#479 > (eval)#479 > Sympa::DataSource::SQL::ANON#53 Unable to connect to SQL data source Sympa::DataSource::SQL <context=atm@boxname.emich.edu;id=cbb530e4;role=member;name=INSTANCE>

I had forgotten a single ' in the query and when I put that in the list successfully updated.

[ikedas]

OK. Thanks for sharing your experiences! Close.

[cgx]

I'm surprise this issue has been closed so quickly. I think the behaviour must be improved. An error message should be displayed when a user defines an invalid SQL query. Would reconsider the issue @ikedas?

[ikedas]

Error message is displayed in the log (and I guess that more detailed logs describing SQL syntax error might also be shown). I don't think it "silent".

[racke]

Well but not sufficient either, it should contain at least the SQL error.

[ikedas]

Well but not sufficient either, it should contain at least the SQL error.

Could you please reproduce “no SQL error”?

[racke]

Not at the moment, but will setup a test case. I refer to a SQL error like

MariaDB [sympa]> select noway from  subscriber_table;
ERROR 1054 (42S22): Unknown column 'noway' in 'field list'

[racke]

Ok, the SQL error is displayed in the log. @skunktoy please provide more information about your specific case.

[skunktoy]

Hey,

Before 6.2.48 the web interface would display an error status of some kind, sorry I don't recall what it said if a bad query was attempted through the web interface - aka attempt to resync the membership list. Now if the query is bad it fails silently on the web interface side, so you have notice that the membership was not updated to look in the logs and see that there is an error.

Usually not an issue but one fat fingering on entering something through web interface and the users get to scratch their heads in confusion.

Thanks!

[racke]

Yes that might be the case. I just opened an issue on a related problem: #907

[skunktoy]

That sounds very similar, and just as confusing.