Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delivery notification to sender for moderated mailing lists #965

Open
Salo15 opened this issue Jun 25, 2020 · 7 comments
Open

delivery notification to sender for moderated mailing lists #965

Salo15 opened this issue Jun 25, 2020 · 7 comments

Comments

@Salo15
Copy link

Salo15 commented Jun 25, 2020

In a moderated mailing list, when an email is confirmed via the Web page, no delivery notification is sent to the sender.
When a mail is released by clicking on the link in the moderation mail, a delivery notification is sent to the sender.

Version

6.2.16

Installation method

Debian Package

Expected behavior

When an e-mail is confirmed via the website a Delivery Notification should also be sent.

Actual behavior

In this case, the sender is not notified that his e-mail was sent via the list.

Additional information

After releasing a mail via the website, I see an entry in the log that looks something like this:
... sympa_msg[1756]: notice Sympa::Request::Message::__parse() Parsing: QUIET DISTRIBUTE listname b49a958147967afxxxxxxxxxxxxxxxxxxx

So the command "distribute" is called with a "Quiet" in front of it.
At what point do I have to change something so that when releasing a mail via the website the command "distribute" is executed without "quiet" and thus a response is sent to the sender?

We have moderators who deliberately moderate their mailing list via the website.
They would like to keep this procedure and they still want a delivery notification to be sent to the sender.

@ikedas
Copy link
Member

ikedas commented Jun 25, 2020

Even on recent version (6.2.56) "quiet" option is hardcoded in web interface. So I added "enhancement" tag to note that improvement is requested.

@Salo15
Copy link
Author

Salo15 commented Jun 29, 2020

Thanks for your quick response.
Is there a possibility that we ourselves change the corresponding line in the code so that a delivery notification is also sent to the sender when mail is released via the website?

@ikedas
Copy link
Member

ikedas commented Jul 1, 2020

On 6.2.16, I think this change may enable notification always:

diff --git a/src/cgi/wwsympa.fcgi.in b/src/cgi/wwsympa.fcgi.in
index 810917d..87e173b 100644
--- a/src/cgi/wwsympa.fcgi.in
+++ b/src/cgi/wwsympa.fcgi.in
@@ -8970,7 +8970,7 @@ sub do_distribute {
             next;
         }
         push @mail_command,
-            sprintf('QUIET DISTRIBUTE %s %s', $list->{'name'}, $id);
+            sprintf('DISTRIBUTE %s %s', $list->{'name'}, $id);

         # TAG
         if ($list_topics) {

@Salo15
Copy link
Author

Salo15 commented Jul 8, 2020

Thank you very much. That helps for the moment and it would be great if that would be implemented in future versions.

@Salo15 Salo15 closed this as completed Jul 8, 2020
@ikedas ikedas reopened this Jul 9, 2020
@laerm
Copy link

laerm commented Sep 14, 2021

I have a user that has just noticed this discrepancy between web interface and email moderation, it seems it is still present in latest release 6.2.64. It would be great if this could be corrected!

@laerm
Copy link

laerm commented Dec 14, 2022

Still present in 6.2.70. Is it planned to add this change into the main release?

@laerm
Copy link

laerm commented Jun 1, 2023

@ikedas still not in the latest release 6.2.72. Could this be added to the next release? It's a bit annoying having to manually fix the code after each upgrade. Thanks for your tireless work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants