Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coding style should be fixed #302

Open
michael-e opened this issue Oct 25, 2017 · 3 comments
Open

Coding style should be fixed #302

michael-e opened this issue Oct 25, 2017 · 3 comments
Assignees
@nitriques
Labels
suggestion

Comments

@michael-e
Copy link
Member

We should fix the extension's coding style (and make it PSR-2 comaptible). However, I suggest to wait until most of the other issues (and pull requests!) are closed.
@nitriques
Copy link
Member

Do you have experience with automated tools ? I've tried phpcs a couple of time, but still need practice with it.

@michael-e
Copy link
Member Author

No, unfortunately not. I prefer Sublime Text packages, because I want to check the result anyway. There are two or three PHPCS-related packages, e.g. https://github.com/adael/SublimePhpCsFixer (You will have to install php-cs-fixer globally for this package to work — composer global require friendsofphp/php-cs-fixer.)

@nitriques
Copy link
Member

Ok thanks!

@nitriques nitriques self-assigned this Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nitriques nitriques

Labels
suggestion
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michael-e @nitriques