From 02ba663b3fc9c3cdfc269146de9a5e9c03421d60 Mon Sep 17 00:00:00 2001 From: ChiTimesChi <88190723+ChiTimesChi@users.noreply.github.com> Date: Mon, 7 Oct 2024 15:04:21 +0100 Subject: [PATCH] docs: add a TODO note wrt encoding changes --- packages/contracts-rfq/contracts/FastBridgeV2.sol | 3 +++ 1 file changed, 3 insertions(+) diff --git a/packages/contracts-rfq/contracts/FastBridgeV2.sol b/packages/contracts-rfq/contracts/FastBridgeV2.sol index b952afa61d..1a64515a33 100644 --- a/packages/contracts-rfq/contracts/FastBridgeV2.sol +++ b/packages/contracts-rfq/contracts/FastBridgeV2.sol @@ -127,6 +127,9 @@ contract FastBridgeV2 is Admin, IFastBridgeV2, IFastBridgeV2Errors { /// @inheritdoc IFastBridge function getBridgeTransaction(bytes memory request) external pure returns (BridgeTransaction memory) { + // TODO: the note below isn't true anymore with the BridgeTransactionV2 struct + // since the variable length `callParams` was added. This needs to be fixed/acknowledged. + // Note: when passing V2 request, this will decode the V1 fields correctly since the new fields were // added as the last fields of the struct and hence the ABI decoder will simply ignore the extra data. return abi.decode(request, (BridgeTransaction));