Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix parsing identifiers from snapshot names #186

Merged
merged 1 commit into from
Apr 15, 2020
Merged

fix: Fix parsing identifiers from snapshot names #186

merged 1 commit into from
Apr 15, 2020

Conversation

taion
Copy link
Contributor

@taion taion commented Apr 15, 2020

Description

This fixes a regression introduced in #177 around generating parsed names from snapshot names with index suffixes.

Related Issues

Checklist

  • This PR has sufficient test coverage.
  • I will merge this pull request with a semantic title.

Additional Comments

No additional comments.

@taion
Copy link
Contributor Author

taion commented Apr 15, 2020

Not sure if I should have checked the "I will merge this pull request" bit.

@noahnu noahnu self-assigned this Apr 15, 2020
taion
taion commented Apr 15, 2020
View reviewed changes
tests/test_integration_default.py
test_content = """
import pytest

def test_case_1(snapshot):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def test_case_1(snapshot):
def test_case(snapshot):

probably?

@noahnu
Copy link
Collaborator

noahnu commented Apr 15, 2020

Very nice catch and thank you for putting this PR together! I'm going to change the base to a temporary branch so we can run our CI suite (we have it disabled for forks at the moment), although I ran our linter and tests locally so I expect everything to work.

And good note on the PR template. You're our first external contributor 😄

@noahnu noahnu changed the base branch from master to temp_PR-186 April 15, 2020 17:57
@noahnu noahnu merged commit 2685fc1 into syrupy-project:temp_PR-186 Apr 15, 2020
@noahnu noahnu mentioned this pull request Apr 15, 2020
Merged
@taion
Copy link
Contributor Author

taion commented Apr 15, 2020

Oh, cool – thanks! This is a great project. My team literally cheered when I told them that there was a better pytest snapshot testing tool out there.

This is a super cool project and it solves so many of the pain points here. Now we won't have to feel slightly bad every time we have to deal with Python snapshots instead of our Jest ones...

@taion taion deleted the fix-valid-id branch April 15, 2020 18:04
noahnu pushed a commit that referenced this pull request Apr 15, 2020
@taion
fix: parsing identifiers from snapshot names (#186) (#187)
45a2931 
Co-authored-by: Jimmy Jia <tesrin@gmail.com>
syrupy-bot pushed a commit that referenced this pull request Apr 15, 2020
@semantic-release-bot
chore(release): 0.3.10 [skip ci]
ff7ea6b 
## [0.3.10](v0.3.9...v0.3.10) (2020-04-15)

### Bug Fixes

* parsing identifiers from snapshot names ([#186](#186)) ([#187](#187)) ([45a2931](45a2931))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@noahnu noahnu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taion @noahnu